Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port.send() should not continue to send a packet if an error occurs when it is encoded #91

Open
colinbdclark opened this issue Jun 14, 2017 · 1 comment

Comments

@colinbdclark
Copy link
Owner

Right now, if a Port encounters an error during the process of sending an OSC packet—for example, if it fails to encode the packet due to errors in its structure—it will continue to attempt to send the message, causing unhelpful exceptions to be thrown.

Instead, osc.js should fire the error event and discontinue its efforts to send the packet. Arguably, if no error event handler is registered, it should do something more drastic such as logging a message or throwing an Error, since without this, the system would fail silently and with the appearance of success.

@colinbdclark
Copy link
Owner Author

Relates to #73, and the semantic for errors at both layers of osc.js is described in more depth in #72.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant