Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG images do not stay in frame in tabs #32

Closed
2 tasks done
Nadine2016 opened this issue Aug 25, 2023 · 7 comments
Closed
2 tasks done

SVG images do not stay in frame in tabs #32

Nadine2016 opened this issue Aug 25, 2023 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@Nadine2016
Copy link

Past Issues Searched

  • I have searched open and closed issues to make sure that the bug has not yet been reported

Issue is a Bug Report

  • This is a bug report and not a feature request, nor asking for support

Describe the bug

When I add an SVG image within the tab shortcode, the image displays but is running out of the frame. PNGs seem to stay within the frame.

Expected behavior

Have SVG images behave the same as PNG images in a tab.

Screenshots

image

Environment

- OS: MacOS
- Browser: Chrome
- Browser Version: 116
@Nadine2016 Nadine2016 changed the title Images do not stay in frame in tabs SVG images do not stay in frame in tabs Aug 25, 2023
@colinwilson colinwilson added the bug Something isn't working label Aug 25, 2023
@colinwilson colinwilson self-assigned this Aug 25, 2023
@colinwilson
Copy link
Owner

Good catch. 👍

I'll push an update to fix this soon.

@Nadine2016
Copy link
Author

Thank you so much!

@colinwilson
Copy link
Owner

@Nadine2016 Are you able to provide a sample SVG image file?

I'm having trouble replicating the behaviour in your screenshot with the few SVG images I've tested.

Also, are you inserting the SVG using regular markdown syntax? e.g. ![my image](/my/image/path/file.svg)

@Nadine2016
Copy link
Author

Nadine2016 commented Aug 29, 2023

@colinwilson

this is the code that I am using

{{< tabs tabTotal="2">}}
{{% tab tabName="GCP" %}}
This is content for GCP. 

![Testimage](/img/core-concepts-apps.svg)
{{% /tab %}}
{{% tab tabName="EKS" %}}
This is content for EKS. 


| Value | Description | 
| -- | -- | 
| Value 1 | Description | 
| Value 2 | Description | 

{{% /tab %}}
{{< /tabs >}}

@Nadine2016
Copy link
Author

core-concepts-apps

And this is an image.

@Nadine2016
Copy link
Author

image

And this is how it looks like for me

@colinwilson
Copy link
Owner

@Nadine2016 Thanks for additional info 👍

Fixed by 5e4c8f1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants