Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sockets] track socket errors #30

Open
b-ma opened this issue May 6, 2021 · 4 comments
Open

[sockets] track socket errors #30

b-ma opened this issue May 6, 2021 · 4 comments

Comments

@b-ma
Copy link
Contributor

b-ma commented May 6, 2021

While this is not a blocking issue, this is not clean and triggers lots of error messages.

note: Find a way to programmatically reproduce the problem, to make sure to track down all possible implications (ghost states, etc.)

@b-ma
Copy link
Contributor Author

b-ma commented Jun 7, 2021

see e060577, (hopefully fixed)

@b-ma
Copy link
Contributor Author

b-ma commented Jun 7, 2021

should do proper tests anyway

@b-ma
Copy link
Contributor Author

b-ma commented Jun 7, 2021

ok it's not...

Error: write EPIPE
    at afterWriteDispatched (internal/stream_base_commons.js:156:25)
    at writevGeneric (internal/stream_base_commons.js:139:3)
    at Socket._writeGeneric (net.js:783:11)
    at Socket._writev (net.js:792:8)
    at doWrite (internal/streams/writable.js:375:12)
    at clearBuffer (internal/streams/writable.js:521:5)
    at Socket.Writable.uncork (internal/streams/writable.js:317:7)
    at Sender.sendFrame (node_modules/ws/lib/sender.js:398:20)
    at Sender.send (node_modules/ws/lib/sender.js:294:12)
    at WebSocket.send (node_modules/ws/lib/websocket.js:361:18) {
  errno: -32,
  code: 'EPIPE',
  syscall: 'write'
}

see websockets/ws#1172

@b-ma
Copy link
Contributor Author

b-ma commented Jun 7, 2021

seems to reproduce when we have minimum 6 emulated clients (i.e. 12 opened sockets) and reload the page.

probably hard to fix as we have lots of race conditions there

@b-ma b-ma changed the title [sockets] check for dead socket connections server-side too [sockets] track socket errors Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant