fix: Timestamp bound queries were not applied when in transaction (#213)

fix/staleness-read-on-tx # Conflicts: # CHANGELOG.md # tests/ConnectionTest.php
colopl · Jun 3, 2024 · 4529a9f · 4529a9f
1 parent 8ab4279
commit 4529a9f
Show file tree

Hide file tree

Showing 3 changed files with 44 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,9 +1,13 @@
+# v7.4.2 (2024-06-03)
+
+Fixed
+- Timestamp bound queries were not applied when in transaction (#213)
+
 # v7.4.1 (2024-05-21)
 
 Fixed
 - authCache needs namespace for each connection (#210)
 
-
 # v7.4.0 (2024-05-13)
 
 Added

diff --git a/src/Connection.php b/src/Connection.php
@@ -578,9 +578,17 @@ protected function executeQuery(string $query, array $bindings, array $options):
             $options['requestOptions']['requestTag'] = $tag;
         }
 
-        if ($transaction = $this->getCurrentTransaction()) {
+        $forceReadOnlyTransaction =
+            ($options['exactStaleness'] ?? false) ||
+            ($options['maxStaleness'] ?? false) ||
+            ($options['minReadTimestamp'] ?? false) ||
+            ($options['readTimestamp'] ?? false) ||
+            ($options['strong'] ?? false);
+
+        if (!$forceReadOnlyTransaction && $transaction = $this->getCurrentTransaction()) {
             return $transaction->execute($query, $options)->rows();
         }
+
         return $this->getSpannerDatabase()->execute($query, $options)->rows();
     }
 

diff --git a/tests/ConnectionTest.php b/tests/ConnectionTest.php
@@ -478,34 +478,59 @@ public function test_stale_reads(): void
         $this->assertNotEmpty($timestamp);
 
         $timestampBound = new StrongRead();
-        $rows = $conn->selectWithOptions("SELECT * FROM ${tableName} WHERE userID = ?", [$uuid], $timestampBound->transactionOptions());
+        $rows = $conn->selectWithOptions("SELECT * FROM {$tableName} WHERE userId = ?", [$uuid], $timestampBound->transactionOptions());
         $this->assertCount(1, $rows);
         $this->assertSame($uuid, $rows[0]['userId']);
         $this->assertSame('first', $rows[0]['name']);
 
         $oldDatetime = Carbon::instance($timestamp->get())->subSecond();
 
         $timestampBound = new ReadTimestamp($oldDatetime);
-        $rows = $conn->selectWithOptions("SELECT * FROM ${tableName} WHERE userID = ?", [$uuid], $timestampBound->transactionOptions());
+        $rows = $conn->selectWithOptions("SELECT * FROM {$tableName} WHERE userId = ?", [$uuid], $timestampBound->transactionOptions());
         $this->assertEmpty($rows);
 
         $timestampBound = new ExactStaleness(10);
-        $rows = $conn->selectWithOptions("SELECT * FROM ${tableName} WHERE userID = ?", [$uuid], $timestampBound->transactionOptions());
+        $rows = $conn->selectWithOptions("SELECT * FROM {$tableName} WHERE userId = ?", [$uuid], $timestampBound->transactionOptions());
         $this->assertEmpty($rows);
 
         $timestampBound = new MaxStaleness(10);
-        $rows = $conn->selectWithOptions("SELECT * FROM ${tableName} WHERE userID = ?", [$uuid], $timestampBound->transactionOptions());
+        $rows = $conn->selectWithOptions("SELECT * FROM {$tableName} WHERE userId = ?", [$uuid], $timestampBound->transactionOptions());
         $this->assertCount(1, $rows);
         $this->assertSame($uuid, $rows[0]['userId']);
         $this->assertSame('first', $rows[0]['name']);
 
         $timestampBound = new MinReadTimestamp($oldDatetime);
-        $rows = $conn->selectWithOptions("SELECT * FROM ${tableName} WHERE userID = ?", [$uuid], $timestampBound->transactionOptions());
+        $rows = $conn->selectWithOptions("SELECT * FROM {$tableName} WHERE userId = ?", [$uuid], $timestampBound->transactionOptions());
         $this->assertCount(1, $rows);
         $this->assertSame($uuid, $rows[0]['userId']);
         $this->assertSame('first', $rows[0]['name']);
     }
 
+    public function test_stale_reads_in_transaction(): void
+    {
+        $conn = $this->getDefaultConnection();
+        $tableName = self::TABLE_NAME_USER;
+        $uuid = $this->generateUuid();
+
+        $conn->transaction(function(Connection $conn) use ($tableName, $uuid) {
+            $conn->insert("INSERT INTO {$tableName} (`userId`, `name`) VALUES ('{$uuid}', 'first')");
+
+            $oldDatetime = now()->subSecond();
+
+            $bounds = [
+                new StrongRead(),
+                new ExactStaleness(10),
+                new MaxStaleness(10),
+                new ReadTimestamp($oldDatetime),
+                new MinReadTimestamp($oldDatetime),
+            ];
+            foreach ($bounds as $timestampBound) {
+                $rows = $conn->selectWithOptions("SELECT * FROM {$tableName} WHERE userId = ?", [$uuid], $timestampBound->transactionOptions());
+                $this->assertEmpty($rows);
+            }
+        });
+    }
+
     public function testEventListenOrder(): void
     {
         $receivedEventClasses = [];