Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TYP: import Axes and Figure from canonical locations #1201

Closed

Conversation

tacaswell
Copy link
Contributor

Following up on matplotlib/matplotlib#26837

This is very mechanical change for Axes and Figure (mostly sed + manually fixing up imports).

Do not import from matplotlib.pyplot
@KelSolaar
Copy link
Member

Thank @tacaswell! I actually fixed those here: https://github.com/colour-science/colour/actions/runs/6259453375 but it is not merged yet. I will still cherry-pick/merge your commit to showcase your contribution!

KelSolaar added a commit that referenced this pull request Sep 22, 2023
References #1201.

Co-authored-by: Thomas A Caswell <[email protected]>
@KelSolaar
Copy link
Member

Closing this one in favour of 66e3e1f, thanks @tacaswell!

@KelSolaar KelSolaar closed this Sep 22, 2023
@KelSolaar KelSolaar added this to the v0.4.4 milestone Sep 22, 2023
@tacaswell tacaswell deleted the fix/use_correct_imports branch September 22, 2023 23:23
@tacaswell tacaswell restored the fix/use_correct_imports branch December 11, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants