Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows support #4

Open
jszwedko opened this issue Dec 28, 2021 · 1 comment
Open

Windows support #4

jszwedko opened this issue Dec 28, 2021 · 1 comment

Comments

@jszwedko
Copy link

Hi all!

Thank you for creating this Github Action! We started using it with our self-hosted runners for https://github.com/vectordotdev/vector when we ran into issues with disk space.

I was just curious if you'd be open to contributions adding support for Windows? We have self-hosted Windows runners that it would be nice to use this with too.

Thank you!

@nafarlee
Copy link
Member

@jszwedko

I personally would not be opposed to supporting Windows for this action (the more the merrier!), but I don't think it is possible without drastically changing the way the action works unfortunately.

Running containers via normal means with GitHub Actions are only supported on Linux according to GitHub:

As this action is container-based (and there isn't any way of doing a "mixed" action to my knowledge), supporting Windows would require transitioning this action to be of type JavaScript or composite, both of which have other downsides.

If any of this changes in the future (or if there is some opportunity I missed), I would be happy to add (or accept a PR for) the functionality!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants