Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

Notification are sent despite box being unchecked #85

Open
JulienTant opened this issue Oct 30, 2021 · 1 comment · Fixed by #75
Open

Notification are sent despite box being unchecked #85

JulienTant opened this issue Oct 30, 2021 · 1 comment · Fixed by #75
Assignees
@coltoneshaw
Labels
bug Something isn't working
Milestone
v1.1.0

Comments

@JulienTant
Copy link
Contributor

Describe the bug
The notifications are sent despite the box being unchecked.

To Reproduce
Steps to reproduce the behavior:

  1. Start 3CPM
  2. Uncheck the notification checkbox
  3. Refresh after a deal closed
  4. See the notification

Expected behavior
The notification should not appear

Screenshots
Screenshot from 2021-10-30 16-51-11

Desktop (please complete the following information):

  • OS: Ubuntu
  • Browser: N/A
  • Version: branch main
@JulienTant JulienTant added the bug Something isn't working label Oct 30, 2021
@coltoneshaw coltoneshaw linked a pull request Nov 2, 2021 that will close this issue
Fix notifications settings that were not remembered #75
Merged
@coltoneshaw coltoneshaw added this to the v1.1.0 milestone Nov 2, 2021
@coltoneshaw
Copy link
Owner

@JulienTant - I believe this is fixed in #75 . I accidentally was testing with notifications disabled for a while. Can you pull the latest v1.0.1 branch and see if this is now fixed?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@coltoneshaw coltoneshaw

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

Fix notifications settings that were not remembered petitcl/3c-portfolio-manager
2 participants
@JulienTant @coltoneshaw