Skip to content

Conversation

@deanlee
Copy link
Contributor

@deanlee deanlee commented Oct 21, 2025

resolve #36329
2025-10-21_14-29
2025-10-21_14-30

@github-actions github-actions bot added the ui label Oct 21, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2025

raylib UI Preview

settings_software : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
settings_software_download : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
All Screenshots

@deanlee deanlee marked this pull request as ready for review October 22, 2025 02:09
@sshane
Copy link
Contributor

sshane commented Oct 22, 2025

my branch has some bug fixes, did you add those? we should do separately first

@sshane sshane merged commit 856f8d3 into commaai:master Oct 22, 2025
13 checks passed
@sshane
Copy link
Contributor

sshane commented Oct 22, 2025

nvm can fix later. thanks!

@deanlee deanlee deleted the ui-select-branch branch October 23, 2025 00:14
sshane added a commit that referenced this pull request Oct 23, 2025
@sshane
Copy link
Contributor

sshane commented Oct 23, 2025

reverting, this was missing quite a few things from #36359 like only showing on release branches and dialog fixes which made it more difficult to merge my pr

selected = self._select_branch_dialog.selection
self._target_branch_btn.action_item.set_value(selected)
ui_state.params.put("UpdaterTargetBranch", selected)
os.system("pkill -SIGHUP -f system.updated.updated")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Qt uses SIGUSR1 for branch switching

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

raylib: add branch switcher

2 participants