Convert to pytest #1982
Convert to pytest #1982
Conversation
|
@UkuLoskit Do you plan on finishing this up soon? |
|
@maxime-desroches hey, ready for review now with some caveats described in the PR description. |
|
There are actually more tests ... fixing these |
|
trigger-jenkins |
|
|
||
| def test_tx_hook_on_wrong_safety_mode(self): | ||
| # No point, since we allow many diagnostic addresses | ||
| pass | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| unittest.main() | ||
| pytest.main() |
There was a problem hiding this comment.
the linter should be configured to block this. how is it passing?
| @@ -10,6 +10,3 @@ flake8-implicit-str-concat.allow-multiline=false | |||
|
|
|||
| [tool.ruff.lint.flake8-tidy-imports.banned-api] | |||
| "pytest.main".msg = "pytest.main requires special handling that is easy to mess up!" | |||
|
|
|||
| [tool.pytest.ini_options] | |||
| addopts = "-n auto" | |||
There was a problem hiding this comment.
why was this removed? we want parallel by default
|
|
||
| @pytest.mark.order(1) |
There was a problem hiding this comment.
why is this needed? the tests should be independent
There was a problem hiding this comment.
@adeebshihadeh I have explained this in PR description The tests are dependent on a definite ordering which be reproduced even without any changes with the unittest package if you change the method names. E.g test_aaa... for the order(5) five test for example. This ordering is just a hack, because fixing the tests to be independent seemed to be a more complicated task that I wanted to skip at least initially
There was a problem hiding this comment.
@adeebshihadeh just bumping this since I haven't heard anything back in a while. I think the easiest way to allow parallelism would be to mark the tests that depend on a particular order to run serially. that way parallelism could still be used for other tests. Fixing the tests themselves, seems like a more complicated task.
|
Closing, I left feedback and it wasn't addressed. Feel free to open a new one without any "crutches". More background here. |
There is an issue with the usbprotocol tests, they depend on a particular ordering of the tests. I used pytest-order to preserve the default ordering of unittest. Additionally, these tests cannot be run in parallel. Used this ordering as a crutch to work around this.