Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data Editor performance #530

Open
plucik opened this issue Oct 23, 2024 · 0 comments
Open

Data Editor performance #530

plucik opened this issue Oct 23, 2024 · 0 comments
Assignees
@plucik
Labels
enhancement New feature or request
Milestone
1.3

Comments

@plucik
Copy link
Collaborator

plucik commented Oct 23, 2024

Currently, with each cell edit or row delete/revert in the data editor, the entire table is replaced with new data. This means that for every change, the data for the whole table is updated. We may need to consider a better approach by replacing only the necessary cells, checking cell metadata, and potentially filtering the cells that need to be updated.
@plucik plucik added the enhancement New feature or request label Oct 23, 2024
@plucik plucik added this to the 1.3 milestone Oct 23, 2024
@plucik plucik self-assigned this Nov 5, 2024
plucik added a commit that referenced this issue Nov 7, 2024
@plucik
improves data editor rendering performance refs: #530
27402b5 
changes actionsCol field from '0' to 'rowMeta'
adds id field to rows before adding them to tabulator
removes watcher that replaces tabulator data on every change
row delete/edit/revert doesn't trigger replace all data
@plucik plucik mentioned this issue Nov 7, 2024
Merged
eug3nix pushed a commit that referenced this issue Nov 7, 2024
@plucik
530 data editor performance (#548)
ea63bd5 
improves data editor rendering performance refs: #530
changes actionsCol field from '0' to 'rowMeta'
adds id field to rows before adding them to tabulator
removes watcher that replaces tabulator data on every change
row delete/edit/revert doesn't trigger replace all data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plucik plucik

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.3
Development

When branches are created from issues, their pull requests are automatically linked.

530-data-editor-performance commandprompt/pgmanage
1 participant
@plucik