Skip to content
This repository has been archived by the owner on May 24, 2023. It is now read-only.

Commit

Permalink
Merge pull request #48 from commercetools/update_api_versions
Browse files Browse the repository at this point in the history
update api-versions for public services.
  • Loading branch information
ahalberkamp authored Oct 7, 2022
2 parents 8c8783f + 2aa7de4 commit 09191aa
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 8 deletions.
2 changes: 1 addition & 1 deletion charts/public-service/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: v1
name: public-service
description: Helm chart for deploying an instance of a publicly available service on a K8s cluster (via HTTP from outside the cluster).
version: 1.0.11
version: 1.1.0
16 changes: 11 additions & 5 deletions charts/public-service/templates/ingress.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{{- if .Values.ingress.enabled -}}
{{- $fullName := include "public-service.fullname" . -}}
{{- $ingressPath := .Values.ingress.path -}}
apiVersion: networking.k8s.io/v1beta1
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
name: {{ $fullName }}
Expand Down Expand Up @@ -31,18 +31,24 @@ spec:
http:
paths:
- path: {{ $ingressPath }}
pathType: ImplementationSpecific
backend:
serviceName: {{ $fullName }}
servicePort: service-port
service:
name: {{ $fullName }}
port:
name: service-port
{{- end }}
# If no hosts are defined, a default path for the backend mapping has to be defined
{{- if not .Values.ingress.hosts }}
- http:
paths:
- path: {{ $ingressPath }}
pathType: ImplementationSpecific
backend:
serviceName: {{ $fullName }}
servicePort: service-port
service:
name: {{ $fullName }}
port:
name: service-port

{{- end }}
{{- end }}
2 changes: 1 addition & 1 deletion charts/public-service/templates/managedCertificate.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{- if .Values.managecertificate.enabled -}}
apiVersion: networking.gke.io/v1beta2
apiVersion: networking.gke.io/v1
kind: ManagedCertificate
metadata:
name: {{ .Values.managecertificate.name }}
Expand Down
2 changes: 1 addition & 1 deletion charts/public-service/templates/poddisruptionbudgets.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{{- if .Values.pdb.enabled -}}
{{- $fullName := include "public-service.fullname" . -}}
apiVersion: policy/v1beta1
apiVersion: policy/v1
kind: PodDisruptionBudget
metadata:
name: {{ $fullName }}
Expand Down

0 comments on commit 09191aa

Please sign in to comment.