Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate branch name in preview release workflow #3663

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

CarlosCortizasCT
Copy link
Contributor

Summary

Validate branch name in preview release workflow

Description

We detected some attempts to exploit the new workflow for preview releases so we want to include a quick and simple validation for the branch names we use in order to protect the flow.

We now only allow numbers, letters, underscores, and hyphens in the branch name.

@CarlosCortizasCT CarlosCortizasCT requested a review from a team as a code owner December 2, 2024 10:42
Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mc-app-kit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 10:49am
merchant-center-application-kit-components-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 10:49am

Copy link

changeset-bot bot commented Dec 2, 2024

⚠️ No Changeset found

Latest commit: 7376b60

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@emmenko emmenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@CarlosCortizasCT CarlosCortizasCT merged commit 196d69b into main Dec 2, 2024
19 checks passed
@CarlosCortizasCT CarlosCortizasCT deleted the cm-prerelease-action-validation branch December 2, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fe-chapter-rotation Tasks coming from frontend chapter work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants