[FEC-157] Update prerelease workflow #3664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CarlosCortizasCT
added
the
fe-chapter-rotation
CarlosCortizasCT
changed the title
Rhotimee
approved these changes
Dec 2, 2024
|
@commercetools/shield-team-fe could you help merging this PR? It seems there's some problem with the VRTs, but this PR only changes a GitHub workflow. Any clue from your side?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update prerelease workflow
Description
The initial goal of this PR was to fix an error we currently have in the prerelease workflow regarding an invalid version number we're using for the
myrotvorets/set-commit-status-action@v2action:That action has not published any
v2tag so we need to use a specific version. I was suggesting to use the latest available (2.0.1).You can take a look at this PR's first commit.
Afterwards, I thought about the purpose of using that action in the workflow: it seems we want to set a visual mark on the last commit before the preview release comment was written.
Since that mark is very subtle (visually) and we are also adding a comment when the release process in finished so we know whether it went well or not, my second commit in this PR is my proposal to remove those steps from the workflow as I believe the code we add to the workflow does not outweigh the benefits we get from it.
Of course, open for discussion.