-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix preview releases workflow #3665
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
contents: read | ||
pull-requests: write | ||
issues: write | ||
statuses: write |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one was a leftover of a previous implementation.
@commercetools/shield-team-fe again stuck because of Percy. Could you please help? 🙏 |
I can't see any issues with Percy...somehow the status check is not reported back to github. |
@CarlosCortizasCT @emmenko ok, so it's not just ui-kit where percy is hanging - did you remove percy from branch protections to get around this? |
No, as an admin I can bypass the branch protection. If it's blocking people, we can remove the required status check for the time being. |
I just removed the required status in ui-kit because it was holding up auto-merges, I'll keep checking in on the integration in uikit and here and re-enable it if/when it starts to return on success again |
Summary
The preview release workflow was not working because one permission was missing.