Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix preview releases workflow #3665

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

CarlosCortizasCT
Copy link
Contributor

Summary

The preview release workflow was not working because one permission was missing.

@CarlosCortizasCT CarlosCortizasCT added the fe-chapter-rotation Tasks coming from frontend chapter work label Dec 4, 2024
@CarlosCortizasCT CarlosCortizasCT self-assigned this Dec 4, 2024
@CarlosCortizasCT CarlosCortizasCT requested a review from a team as a code owner December 4, 2024 12:03
Copy link

changeset-bot bot commented Dec 4, 2024

⚠️ No Changeset found

Latest commit: 6881445

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mc-app-kit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 0:04am
merchant-center-application-kit-components-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 0:04am

contents: read
pull-requests: write
issues: write
statuses: write
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one was a leftover of a previous implementation.

@CarlosCortizasCT
Copy link
Contributor Author

@commercetools/shield-team-fe again stuck because of Percy. Could you please help? 🙏

@emmenko
Copy link
Member

emmenko commented Dec 4, 2024

I can't see any issues with Percy...somehow the status check is not reported back to github.

@emmenko emmenko merged commit 1212930 into main Dec 4, 2024
17 checks passed
@emmenko emmenko deleted the cm-update-preview-release-workflow branch December 4, 2024 14:15
@ByronDWall
Copy link
Contributor

@CarlosCortizasCT @emmenko ok, so it's not just ui-kit where percy is hanging - did you remove percy from branch protections to get around this?

@emmenko
Copy link
Member

emmenko commented Dec 4, 2024

No, as an admin I can bypass the branch protection.

If it's blocking people, we can remove the required status check for the time being.

@ByronDWall
Copy link
Contributor

I just removed the required status in ui-kit because it was holding up auto-merges, I'll keep checking in on the integration in uikit and here and re-enable it if/when it starts to return on success again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fe-chapter-rotation Tasks coming from frontend chapter work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants