Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xlsx-1.1.2.2 fails to compile #7670

Closed
alaendle opened this issue Feb 2, 2025 · 3 comments
Closed

xlsx-1.1.2.2 fails to compile #7670

alaendle opened this issue Feb 2, 2025 · 3 comments

Comments

@alaendle
Copy link
Member

alaendle commented Feb 2, 2025

 /home/curators/work/unpack-dir/unpacked/xlsx-1.1.2.2-56ddf5b75ffa0673bcf4a571ec74cfa628c688dab8c2024cd1397b82aba1930d/src/Codec/Xlsx/Writer/Stream.hs:268:35: error: [GHC-22385]
           Not in scope: record field ‘rsPretty’
           |
       268 | writeEvents = renderBuilder (def {rsPretty=False})
           |       

rsPretty was removed in new version of xml-conduit.

https://hackage.haskell.org/package/xml-conduit-1.9.1.4/docs/Text-XML-Stream-Render.html#v:rsPretty

FYI @qrilka

alaendle added a commit that referenced this issue Feb 2, 2025
@qrilka
Copy link
Contributor

qrilka commented Feb 2, 2025

@alaendle thanks for tagging me, I'd be glad to review a PR with a fix

@alaendle
Copy link
Member Author

alaendle commented Feb 2, 2025

I didn't mean to be pushy, I noticed the whole thing while curating stackage. Since you (@qrilka) are mentioned as a maintainer, the tagging - but I (personally) won't create a PR (simply because we (the curators) couldn't do this for all the problems we reveal) - but as you said, contributions are welcome!

"Kirill Zaborsky <[email protected]> @qrilka":
- xlsx < 0 # 1.1.2.2 fails to compile https://github.com/commercialhaskell/stackage/issues/7670

@qrilka
Copy link
Contributor

qrilka commented Feb 8, 2025

Version 1.1.3 is on Hackage, tested it with nightly-2025-02-08 and seems to be fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants