Better way to add the { analytics } prop type to NextPage?

[omarryhan]

Thanks for the awesome package!

Minor question. Is there a way to make TS infer the extra { analytics } prop without importing my custom _App props in every page?

Also, is there a specific reason why the Readme.md is in JS and not TS? I can help add TS code instructions if you're open to it.

[omarryhan]

I'm a bit confused, why use the analytics prop and the attached helpers when you can just import ReactGA and use it directly? Is there something I'm missing?

If there's no difference, then I think that importing ReactGA should be the recommended way. What do you think?

[omarryhan]

Two more things 😅,

1. In prod.ts and dev.ts, you're using:

if (typeof window !== 'undefined') {
    ... doSth()
}

inconsistently. At first, I thought that was not to make the app fail on build time (when there is no window object) or when SSRing. But then, I saw that it worked fine with the real ReactGA object.

2. I think it's better to directly expose React GA's interfaces. It will make your life easier as a maintainer because you won't have to keep updating types whenever ReactGA do any changes to their interface.

Same goes with WithAnalyticsConfig It's better to use ReactGA's own config interface.

Let me know what you think. If you agree, I can work on a PR to address these issues.

[resir014]

@omarryhan Hey, sorry for the delayed response.

I initially set it that way since I had plans to include the ability to hook in other analytics solutions, but since we're focusing on the GA experience right now we might accept your changes.

If you're still up for it, feel free to send a PR!