Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide keyboard on next button click #5269

Closed
wants to merge 1 commit into from

Conversation

shankarpriyank
Copy link
Contributor

I thought it might a minor improvement in the UX if the keyboard is hidden on next button click, as there are a lot of cases in which a dialog box might appear and dialogboxes and keyboard do not look together, but again its just my personal opinion.
Just added a couple of lines to hide the keyboard on next button click

@shankarpriyank
Copy link
Contributor Author

Also @nicolas-raoul, uploading of images is not working at all for me.
I tried it with all sort of images, they all just fail. not sure why are they failing though

@nicolas-raoul
Copy link
Member

Actually we want to encourage people to write captions specific to each picture.
For instance if they upload 3 pictures, it would be better if they enter a different caption for each.
Hiding the keyboard on "Next" would add one step for entering a specific description, and thus would go against that goal... if anything, forcing the keyboard to be visible on Next might be better, feel free to create an enhancement issue about that. Meanwhile I will close this pull request, but part of the code can probably be reused in the future so please mention its URL if you create the issue.

About uploading: Current master should work much better now. :-)

Thanks! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants