Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aarch64 binaries to releases? #120

Open
adamrankin opened this issue Feb 11, 2021 · 9 comments
Open

Add aarch64 binaries to releases? #120

adamrankin opened this issue Feb 11, 2021 · 9 comments

Comments

@adamrankin
Copy link

Hello,

Is it possible to include a binary build for aarch64 into the releases?

@jcfr
Copy link
Member

jcfr commented Feb 11, 2021

That should indeed be possible. We would be happy to review contributions.

Here are the steps:

@adamrankin
Copy link
Author

The static build of Qt is 4.8.6. Did you want to continue using that version?

@jcfr
Copy link
Member

jcfr commented Feb 11, 2021

The static build of Qt is 4.8.6. Did you want to continue using that version?

If you already have a Qt build for aarch64 and it 4.8.6, that is a good starting point.

What do you think of creating a release called applauncher-4.8.6-aarch64 in https://github.com/jcfr/qt-static-build/releases and update the README ?

If that sounds good, I will create the release and grant access so that we you can update the release description, upload file and describe how it was generated.

@adamrankin
Copy link
Author

adamrankin commented Feb 11, 2021

I'm still trying to wrap my head around all the automated build system stuff. Would this not be the same as the linux docker image, just with a different base image?

Edit: what I mean by automated build system understanding: can we add another entry to the circleCI system to also build aarch64, just have a different Qt-static docker image?

@adamrankin
Copy link
Author

adamrankin commented Feb 12, 2021

Ok, @jcfr I've made a docker image with Qt 5.12.10 built. Should I zip up the Qt build folder inside and upload it to a release?

Edit (links):
Docker makefile and dockerfile here:
https://github.com/adamrankin/qt-static-build

Docker image here:
https://hub.docker.com/layers/adamrankin/qt-static/5.12.10-ubuntu-20.04/images/sha256-adf327868df7a2e009d507376ce16333b3c8430a177b5b32b75efcf6c975ac94?context=explore

@jcfr
Copy link
Member

jcfr commented Feb 19, 2021

made a docker image with Qt 5.12.10 built

This is great.

I suggest the following next steps:

  • check that you can run the test from the build tree of the AppLauncher
  • check that the binary created can be run on the target platform (you can do make package to first create an archive)

@adamrankin
Copy link
Author

Good call. libpng linking issues! Will update when I have a working package.

@adamrankin
Copy link
Author

Should I redo my docker image to be based on a dockcross image? With my current docker image it would require an arm64 host to build the image

@adamrankin
Copy link
Author

adamrankin commented Feb 22, 2021

Edit: nevermind. I need to learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants