Replies: 1 comment
-
For clarity on the second option, I'm suggesting two variables so that the branch to disable transcode is only applied when the app script has what could be called a feature flag set. This means the advanced settings would only show it for apps that can even use transcoding. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
In #1204, the OP indicated they've got a motherboard the presents /dev/dri/renderD128, but it's not functional in the container and breaks the setup of the container before it even gets to the point of installing the application.
Looking at what I've seen of the installation flow, it should be possible to
build.func
to totally disable creating any pass through or mount of the devices$APP
being one of a hard-coded list in lieu of the$var_transcode_support
check (in build.func ~830)This would be a relatively small PR.
However, I think there's a way that might be better. My criteria for better is "remove the hard-coded check by app name completely, instead of moving it to a whiptail dialog gating check".
This would be a bit of a larger PR.
Folks who steward this project - if either path seems acceptable, I can produce some PRs in the next week or so; work starts again tomorrow, so my time (and enthusiasm) for working on this stuff after my daytime hours will reduce (as I write code all day long).
Beta Was this translation helpful? Give feedback.
All reactions