Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frame scaling #196

Open
petrasvestartas opened this issue Nov 6, 2023 · 2 comments
Open

Frame scaling #196

petrasvestartas opened this issue Nov 6, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@petrasvestartas
Copy link

petrasvestartas commented Nov 6, 2023

This is a question related to scaling of the Frame.
Should the frame edge length be reset after scaling?
Or the Frame could have its own shader, instead being created as a geometry object.

When written:
my_frame.matrix = Scale.from_factors([scale, scale, scale]).matrix

Example: user has a model that is scaled by 0.001, the frames in this situation looks like points:
image

For sure the other way around is to scale the compas frame and do not touch the viewer matrix.
image

@ZacZhangzhuo
Copy link
Collaborator

Thanks for the suggestion! I think the best way is to integrate the variable 'frame view scale' into the configuration file so the user can set the frame size as they want!

@ZacZhangzhuo ZacZhangzhuo self-assigned this Nov 10, 2023
@ZacZhangzhuo ZacZhangzhuo added the enhancement New feature or request label Nov 10, 2023
@petrasvestartas
Copy link
Author

@ZacZhangzhuo
Completely agree, it would be great to have such global attributes that are controlled independently of geometry :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants