-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update employees listed under "Meet the team" on About page #242
Comments
Ugh, why do the images themselves have rounded corners vs. we just do that in CSS? Does anyone know the corner radius for these images? @AnthonyRollins @angela-tran @machikoyasuda In the past, who has prepared an image for the website from the raw illustration files? |
It looks like originally the images were prepared by Segacy based on these comments: I'm not sure who has been preparing them when we add new team members, e.g. in PR #193. Would it be easier to make all the images not have rounded corners and then apply a border-radius through CSS? |
Yeah I figured it was a mix of folks.
I think it would mean one less step in the preparation process if we applied the border-radius through CSS. My process was:
However, that means unapplying the border-radius from all the existing images, which could take some time... |
I like the approach of using CSS instead for the rounded corners 👍 (when I worked on PR #193 it was tricky to resize the images and round the corners in GIMP to match the existing images). So I quickly batch resized the original images that are saved here (and that originally have regular corners) to try to match the size of the current ones on the site, and they look good on my local development server. Looks like we'd only need to replace the current images with these new ones and @thekaveman's PR #252 will close this issue without any other code changes since the classes |
The text was updated successfully, but these errors were encountered: