Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update employees listed under "Meet the team" on About page #242

Closed
4 tasks
angela-tran opened this issue Oct 2, 2024 · 4 comments · Fixed by #252
Closed
4 tasks

Update employees listed under "Meet the team" on About page #242

angela-tran opened this issue Oct 2, 2024 · 4 comments · Fixed by #252
Assignees

Comments

@angela-tran
Copy link
Member

angela-tran commented Oct 2, 2024

  • Add Andy Product Manager
  • Add Leela Senior Project Manager
  • Remove Marissa
  • Remove Sarah
@thekaveman thekaveman self-assigned this Nov 22, 2024
@thekaveman thekaveman moved this from Backlog to In Progress in Compiler Internal Nov 22, 2024
@thekaveman
Copy link
Member

thekaveman commented Nov 22, 2024

Ugh, why do the images themselves have rounded corners vs. we just do that in CSS?

Does anyone know the corner radius for these images? @AnthonyRollins @angela-tran @machikoyasuda

In the past, who has prepared an image for the website from the raw illustration files?

@angela-tran
Copy link
Member Author

angela-tran commented Nov 22, 2024

Ugh, why do the images themselves have rounded corners vs. we just do that in CSS?

Does anyone know the corner radius for these images? @AnthonyRollins @angela-tran @machikoyasuda

In the past, who has prepared an image for the website from the raw illustration files?

It looks like originally the images were prepared by Segacy based on these comments:
#66 (comment)
#66 (comment)

I'm not sure who has been preparing them when we add new team members, e.g. in PR #193.
(edit: looks like maybe Sarah prepared the images for those new team members - see #183 (comment))

Would it be easier to make all the images not have rounded corners and then apply a border-radius through CSS?

@thekaveman
Copy link
Member

I'm not sure who has been preparing them when we add new team members

Yeah I figured it was a mix of folks.

Would it be easier to make all the images not have rounded corners and then apply a border-radius through CSS?

I think it would mean one less step in the preparation process if we applied the border-radius through CSS. My process was:

  1. Click link from Anthony above to raw .png, download locally, open in GIMP
  2. Add layer for background color (white) since default background is transparent
  3. Crop image to roughly the dimensions we want
  4. Scale image to 300x267 pixels
  5. have to apply border radius in GIMP

However, that means unapplying the border-radius from all the existing images, which could take some time...

@lalver1
Copy link
Member

lalver1 commented Dec 2, 2024

I like the approach of using CSS instead for the rounded corners 👍 (when I worked on PR #193 it was tricky to resize the images and round the corners in GIMP to match the existing images). So I quickly batch resized the original images that are saved here (and that originally have regular corners) to try to match the size of the current ones on the site, and they look good on my local development server.

Looks like we'd only need to replace the current images with these new ones and @thekaveman's PR #252 will close this issue without any other code changes since the classes bg-white rounded are already set on the images. Would it be ok for me to add a commit to my local branch with these new images and push to your chore/team branch @thekaveman?

@github-project-automation github-project-automation bot moved this from In Progress to Done in Compiler Internal Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants