Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the Replace constructor argument order #2883

Closed
harendra-kumar opened this issue Nov 17, 2024 · 3 comments · Fixed by #2901
Closed

Change the Replace constructor argument order #2883

harendra-kumar opened this issue Nov 17, 2024 · 3 comments · Fixed by #2901
Labels
aspect:api Related to api change
Milestone

Comments

@harendra-kumar
Copy link
Member

In incremental folds:

data Incr a =
      Insert !a
    | Replace !a !a -- ^ Replace new old

Replace old new may read better as "replace old by new".

@harendra-kumar harendra-kumar added the aspect:api Related to api change label Nov 17, 2024
@harendra-kumar harendra-kumar added this to the 0.11.0 milestone Nov 17, 2024
@adithyaov
Copy link
Member

adithyaov commented Dec 4, 2024

Both make sense to me depending on the picture of how a window looks in my mind.
Insert new and Evict old vs Replace old by new
Is there a compelling argument for the proposal?

@adithyaov
Copy link
Member

Need to also change it in,

  • streamly-indicators
  • streamly-statistics

@adithyaov
Copy link
Member

Check if the intuition is proper. Look at a few combinators and check.

@adithyaov adithyaov linked a pull request Dec 15, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aspect:api Related to api change
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants