Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLEUTHING - Refactor migrator UI and use sleuth to query #76

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

SLEUTHING - Refactor migrator UI and use sleuth to query #76

wants to merge 11 commits into from

Conversation

mykelp
Copy link
Contributor

@mykelp mykelp commented Jan 4, 2023

This patch makes the migrator UI generic between aave and compound migration sources. In addition, this patch utilizes sleuth for fetching data. Previously, we relied on the rpc method setCometState for receiving data about the given account within comet. This patch updates to include fetching comet data directly through sleuth queries

@mykelp mykelp temporarily deployed to Production January 4, 2023 02:02 — with GitHub Actions Inactive
kevjin
kevjin approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@kevjin kevjin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hopefully subsequent changes to sleuth contracts result in a much smaller diff footprint, but this is great, love the refactors and using sleuth cleans up so much of the otherwise large list of multicalls

one thing we should do before merge, is whitelist the sleuth contract in our infux proxy worker - on it rn

@kevjin
Copy link
Contributor

kevjin commented Jan 4, 2023

Also since there were significant changes, the bundled js has changed and we need to update our smart order router hack as well
image

@mykelp mykelp temporarily deployed to Production January 4, 2023 18:41 — with GitHub Actions Inactive
@mykelp mykelp temporarily deployed to Production January 4, 2023 19:33 — with GitHub Actions Inactive
@mykelp mykelp temporarily deployed to Production January 4, 2023 22:06 — with GitHub Actions Inactive
@mykelp mykelp temporarily deployed to Production January 5, 2023 18:11 — with GitHub Actions Inactive
@mykelp mykelp temporarily deployed to Production January 5, 2023 19:17 — with GitHub Actions Inactive
@kevincheng96
Copy link
Contributor

Any idea why the forge tests are failing?

@mykelp
Copy link
Contributor Author

mykelp commented Jan 11, 2023

Any idea why the forge tests are failing?

I'm not quite sure. It seems like some forge regression, because if you run the tests on main it was failing for me also

@mykelp mykelp temporarily deployed to Production January 12, 2023 02:30 — with GitHub Actions Inactive
@Jonboy697989
Copy link

0xc9B9Ec92654c1baF07C20B4B4b87D824fF5744C6 this is were I need it to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevjin kevjin kevjin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mykelp @kevjin @kevincheng96 @Jonboy697989