fix v2-app Markets link #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryanbhasin
deleted the
aryan/eng-39-bug-using-v2-apps-market-link-never-loads-the-webb3-market
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v2 markets page doesn't load on webb3 when going from the links on Palisade.
after investigation i realized https://app.compound.finance/markets/v2 works, https://app.compound.finance/markets?market=v2 doesn't. so the fix is to correct the URLs since we recently made changes to market deep-linking.
Issue: https://linear.app/compound-finance/issue/ENG-39/bug-using-v2-apps-market-link-never-loads-the-webb3-market-content