From c5aa13cb91665be0df1ac915a52a6de5c8328907 Mon Sep 17 00:00:00 2001
From: Erawat Chamanont <erawat@gmail.com>
Date: Mon, 11 Sep 2023 14:11:27 +0100
Subject: [PATCH] BTHAB-180: Only perform delete if id line item is not empty

---
 Civi/Api4/Action/CaseSalesOrder/SalesOrderSaveAction.php | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Civi/Api4/Action/CaseSalesOrder/SalesOrderSaveAction.php b/Civi/Api4/Action/CaseSalesOrder/SalesOrderSaveAction.php
index df4dadade..29f1e9fbc 100644
--- a/Civi/Api4/Action/CaseSalesOrder/SalesOrderSaveAction.php
+++ b/Civi/Api4/Action/CaseSalesOrder/SalesOrderSaveAction.php
@@ -87,6 +87,10 @@ public function removeStaleLineItems(array $salesOrder) {
 
     $lineItemsInUse = array_column($salesOrder['items'], 'id');
 
+    if (empty($lineItemsInUse)) {
+      return;
+    }
+
     CaseSalesOrderLine::delete()
       ->addWhere('sales_order_id', '=', $salesOrder['id'])
       ->addWhere('id', 'NOT IN', $lineItemsInUse)