Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preferably use quarto actions to publish when they work #3

Closed
jchiquet opened this issue Oct 22, 2022 · 4 comments
Closed

Preferably use quarto actions to publish when they work #3

jchiquet opened this issue Oct 22, 2022 · 4 comments

Comments

@jchiquet
Copy link
Member

The rendering is currently done with a call to 'quarto render' via bash, the quarto publish action not working with conda. An issue has been filed about this. It seems that the compilation is a bit faster by this way, so we would have to gain.

@fradav
Copy link
Contributor

fradav commented Oct 23, 2022

I don’t think not using their official actions is really an issue : ATM their actions are just barebone (they’re just calls to "render/publish") and lack a lot of options.

I don’t understand what do you mean by "compilation is a bit faster", actions can’t speedup compilations, they’re just javascript scripts executed inside a VM.

We could preload the conda env as a pre-render project script, but it will need another action script for that: not worth the hassle, IMHO.

@jchiquet
Copy link
Member Author

I don’t think not using their official actions is really an issue : ATM their actions are just barebone (they’re just calls to "render/publish") and lack a lot of options.

Ok, but in the end, we could expect them having more comprehensive actions, and it is also a way to support them. Anyway, ok to use our own actions.

I don’t understand what do you mean by "compilation is a bit faster", actions can’t speedup compilations, they’re just javascript scripts executed inside a VM.

It was probably due to the use of pip in place of conda.

We could preload the conda env as a pre-render project script, but it will need another action script for that: not worth the hassle, IMHO.

Ok, agree with that. But an example with the possibility of caching the conda-env would be nice. What do you think?

@fradav
Copy link
Contributor

fradav commented Oct 23, 2022

I don’t think not using their official actions is really an issue : ATM their actions are just barebone (they’re just calls to "render/publish") and lack a lot of options.

Ok, but in the end, we could expect them having more comprehensive actions, and it is also a way to support them. Anyway, ok to use our own actions.

I don’t understand what do you mean by "compilation is a bit faster", actions can’t speedup compilations, they’re just javascript scripts executed inside a VM.

It was probably due to the use of pip in place of conda.

Anything is faster than conda 😬
For the CI, I use Micromamba as a drop-in replacement for conda (and compatible with it). It’s several orders of magnitudes faster.

We could preload the conda env as a pre-render project script, but it will need another action script for that: not worth the hassle, IMHO.

Ok, agree with that. But an example with the possibility of caching the conda-env would be nice. What do you think?

It is already in the CI:
image

image

@jchiquet
Copy link
Member Author

Ok thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants