Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev notes #50

Open
jeswr opened this issue Mar 30, 2022 · 2 comments
Open

Dev notes #50

jeswr opened this issue Mar 30, 2022 · 2 comments

Comments

@jeswr
Copy link
Member

jeswr commented Mar 30, 2022

Issue type:

  • ➕ Feature request

Description:

Should probably port this over to componentsjs at some point where the error messages can be fixed but at the moment a few things to note

For an error like the following, add jsdoc to the bus, namely

ErrorResourcesContext: The value "https://linkedsoftwaredependencies.org/bundles/npm/@comunica/bus-optimize-rule/^1.0.0/components/ActorOptimizeRule.jsonld#ActorOptimizeRule_default_bus" for parameter "https://linkedsoftwaredependencies.org/bundles/npm/@comunica/mediator-combine-pipeline/^2.0.0/components/MediatorCombinePipeline.jsonld#MediatorCombinePipeline_args_bus" is not of required range type "(https://linkedsoftwaredependencies.org/bundles/npm/@comunica/core/^2.0.0/components/Bus.jsonld#Bus)<UNKNOWN GENERIC: https://linkedsoftwaredependencies.org/bundles/npm/@comunica/core/^2.0.0/components/Mediator.jsonld#Mediator__generic_A, UNKNOWN GENERIC: https://linkedsoftwaredependencies.org/bundles/npm/@comunica/core/^2.0.0/components/Mediator.jsonld#Mediator__generic_I, UNKNOWN GENERIC: https://linkedsoftwaredependencies.org/bundles/npm/@comunica/core/^2.0.0/components/Mediator.jsonld#Mediator__generic_T, UNKNOWN GENERIC: https://linkedsoftwaredependencies.org/bundles/npm/@comunica/core/^2.0.0/components/Mediator.jsonld#Mediator__generic_O>"
    at Function.throwIncorrectTypeError (/home/jeswr/comunica-latest/comunica/node_modules/componentsjs/lib/preprocess/parameterproperty/ParameterPropertyHandlerRange.js:366:15)
    at ParameterPropertyHandlerRange.captureType (/home/jeswr/comunica-latest/comunica/node_modules/componentsjs/lib/preprocess/parameterproperty/ParameterPropertyHandlerRange.js:37:39)
    at ParameterPropertyHandlerRange.handle (/home/jeswr/comunica-latest/comunica/node_modules/componentsjs/lib/preprocess/parameterproperty/ParameterPropertyHandlerRange.js:19:14)
    at ParameterHandler.applyParameterValues (/home/jeswr/comunica-latest/comunica/node_modules/componentsjs/lib/preprocess/ParameterHandler.js:52:33)
    at ConfigPreprocessorComponentMapped.getParameterValue (/home/jeswr/comunica-latest/comunica/node_modules/componentsjs/lib/preprocess/ConfigPreprocessorComponentMapped.js:56:18)
    at ConstructorArgumentsElementMappingHandlerKeyValue.handleKeyValue (/home/jeswr/comunica-latest/comunica/node_modules/componentsjs/lib/preprocess/constructorargumentsmapping/ConstructorArgumentsElementMappingHandlerKeyValue.js:30:30)
    at ConstructorArgumentsElementMappingHandlerKeyValue.handle (/home/jeswr/comunica-latest/comunica/node_modules/componentsjs/lib/preprocess/constructorargumentsmapping/ConstructorArgumentsElementMappingHandlerKeyValue.js:24:25)
    at ConfigPreprocessorComponentMapped.applyConstructorArgumentsParameters (/home/jeswr/comunica-latest/comunica/node_modules/componentsjs/lib/preprocess/ConfigPreprocessorComponentMapped.js:43:32)
    at ConstructorArgumentsElementMappingHandlerFields.handle (/home/jeswr/comunica-latest/comunica/node_modules/componentsjs/lib/preprocess/constructorargumentsmapping/ConstructorArgumentsElementMappingHandlerFields.js:24:18)
    at ConfigPreprocessorComponentMapped.applyConstructorArgumentsParameters (/home/jeswr/comunica-latest/comunica/node_modules/componentsjs/lib/preprocess/ConfigPreprocessorComponentMapped.js:43:32)
error Command failed with exit code 1.
/**
   * @param args - @defaultNested {<default_bus> a <cc:components/Bus.jsonld#Bus>} bus
   */
@github-actions
Copy link

Thanks for the suggestion!

@jeswr
Copy link
Member Author

jeswr commented Mar 30, 2022

Other common issues with generation

export abstract class ActorRdfUpdateQuadsIntercept extends Actor<IActionRdfUpdateQuadsIntercept, IActorTest, IActorRdfUpdateQuadsInterceptOutput> {

works but

export abstract class ActorRdfUpdateQuadsIntercept extends ActorRdfUpdateQuads

does not - similarly with args

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant