Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[conan-center] Hooks regarding test_package and cpp_info #374

Open
jgsogo opened this issue Dec 14, 2021 · 2 comments
Open

[conan-center] Hooks regarding test_package and cpp_info #374

jgsogo opened this issue Dec 14, 2021 · 2 comments
Assignees

Comments

@jgsogo
Copy link
Contributor

jgsogo commented Dec 14, 2021

I'm proposing three hooks:

  1. Every recipe should have a test_package folder (default name for Conan to run after conan create) (+info: Test other generators: run several tests in test_*/conanfile.py conan-center-index#8389). 🤔 Maybe it is already there.
  2. If cpp_info contains .name or .filename, then (one of) the generators cmake_find_package[_multi] are expected
  3. If cpp_info contains .set_property, then (one of) the generators CMakeDeps, MSBuildDeps, PkgConfigDeps are expected (maybe depending on the property).

Not really sure about the last two entries, not sure if we want (so) many packages with several test_xxxx folders.

@uilianries
Copy link
Member

  1. Every recipe should have a test_package folder (default name for Conan to run after conan create) (+info: [poc] Test other generators: run several tests in test_*/conanfile.py conan-center-index#8389). thinking Maybe it is already there.

Yes, the Hook 24: TEST PACKAGE FOLDER: https://github.com/conan-io/hooks/blob/master/hooks/conan-center.py#L248

@uilianries
Copy link
Member

  1. If cpp_info contains .set_property, then (one of) the generators CMakeDeps, MSBuildDeps, PkgConfigDeps are expected (maybe depending on the property).

We can not adopt it now. We are "migrating" recipes on CCI, supporting both cpp_info.names and set_property at same recipe to be prepared for 2.0, however, new generators are not used yet. We could think about a warning message to consider refactoring the recipe to new generators support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants