Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that a user can leave a collection. #49

Open
colinsullivan opened this issue Apr 11, 2011 · 3 comments
Open

Ensure that a user can leave a collection. #49

colinsullivan opened this issue Apr 11, 2011 · 3 comments

Comments

@colinsullivan
Copy link
Member

After #48 is complete, a user should be able to leave a collection in much the same way (update to use our new modified REST stuff). There might also be some sort of authorization issues here, because the user who is trying to modify the "Collection" object is not the admin. For now just hack this together.

@colinsullivan
Copy link
Member Author

Also ensure that the LeaveCollectionEvent is being created.

colinsullivan pushed a commit that referenced this issue Apr 11, 2011
Also ensured that all events are being created properly, except
for those mentioned in #48 and #49.
@georgi0u
Copy link

So just to elaborate on this, for the sake of my own organization:

The basic problem is that collections model instances can only be edited by administrators of said collection instance.

A user leaving a collection (on the model layer) is semantically equivalent to editing the collection's 'users' field attribute, which is thus disallowed by the above rule.

A fix should involve some sort of conditional check to allow non-administrators to edit only the user's field of a collection.

@ghost ghost assigned georgi0u Apr 23, 2011
@colinsullivan
Copy link
Member Author

Yes, exactly.


Colin Sullivan
colin-sullivan.com
On 23 Apr 2011 16:08, "georgi0u" <
[email protected]>
wrote:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants