Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure runnable urls use https protocol [PT-186645347] #206

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

dougmartin
Copy link
Member

Some of the NGSA activities use http:// urls for the runnable sequence or activity and this causes the Firebase function to not find the resources as they are stored there using https urls.

@dougmartin dougmartin force-pushed the 186645347-ensure-https-runnable-urls branch from 2e55c2c to 11ce5b6 Compare January 10, 2024 15:46
Some of the NGSA activities use http:// urls for the runnable sequence or activity and this causes the Firebase function to not find the resources as they are stored there using https urls.
@dougmartin dougmartin force-pushed the 186645347-ensure-https-runnable-urls branch from 11ce5b6 to f2116a7 Compare January 10, 2024 15:47
Copy link

@433eros 433eros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward change, LGTM

@dougmartin dougmartin merged commit 9e844ce into master Jan 10, 2024
1 of 2 checks passed
@dougmartin dougmartin deleted the 186645347-ensure-https-runnable-urls branch January 10, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants