Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prototype from app/views/portal/student_clazzes/destroy.js.rjs #596

Open
emilywatkins opened this issue Sep 7, 2018 · 1 comment

Comments

@emilywatkins
Copy link
Contributor

Ref #457

  • app/views/portal/student_clazzes/destroy.js.rjs:12 #page.replace_html
  • app/views/portal/student_clazzes/destroy.js.rjs:15 #page.replace
  • app/views/portal/student_clazzes/destroy.js.rjs:3 #page.remove
  • app/views/portal/student_clazzes/destroy.js.rjs:6 #page.replace_html
  • (commented out) app/views/portal/student_clazzes/destroy.js.rjs:9 #page.replace_html
  • page << content usage
@scytacki
Copy link
Member

This is called from the roster page for a class. For example: https://learn.staging.concord.org/portal/classes/13/roster There is a 'remove student' link that confirms the action and then uses it. The code calling it is here:

= link_to_remote I18n.t("RosterRemoveStudent"),

This is not dead code. The best would be to move the whole roster page to portal-pages.
I haven't reviewed it yet, but I assume the roster page has other prototype code in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants