Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap borders are quite light compared to default #364

Closed
KorvinSzanto opened this issue Dec 12, 2024 · 2 comments
Closed

Bootstrap borders are quite light compared to default #364

KorvinSzanto opened this issue Dec 12, 2024 · 2 comments

Comments

@KorvinSzanto
Copy link
Member

KorvinSzanto commented Dec 12, 2024

Compare the two:

Concrete default Bootstrap default
Screenshot 2024-12-11 at 2 06 26 PM Screenshot 2024-12-11 at 2 06 36 PM
$border-color-translucent: rgba(#000, 0.075); $border-color-translucent: rgba($black, .175) !default;

Ours is so light that the borders are hard to distinguish, at first I was thinking my display had settings misconfigured or something.

We should increase the darkness, or maybe use a different color so that our borders are distinguished against the drop shadow.

@aembler
Copy link
Member

aembler commented Dec 12, 2024

This is generally done by design – bootstrap is many things but I'm not sure I'd call its design out of the box very attractive. Years ago we experimented with forms that had no fields (per Franz's interest) (similar to material design at the time.) While that was too over the top, the goal was to make our UI less "chunky". I'm not sure that making all the borders more prominent accomplishes that.

@KorvinSzanto
Copy link
Member Author

Bootstrap tries to work within their accessibility requirements, and contrast is a big part of that.

It'd be better to tweak borders at a more granular level, like for form-controls, and not globally for everything with a semitransparent border like we have today.

@aembler aembler closed this as completed Jan 6, 2025
@KorvinSzanto KorvinSzanto closed this as not planned Won't fix, can't repro, duplicate, stale Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants