Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pin for libsvm #1099

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update the pin for libsvm. The current pinned version is 3.21, the latest available version is 324 and the max pin pattern is x.x. This migration will impact 1 feedstocks.

Notes and instructions for merging this PR:

  1. Please merge the PR only if this new version is to be a supported pin.
  2. Feel free to push to the bot's branch to update this PR if needed.
  3. Please make sure to properly bump the version and build number of the pinnings package.

**Please note that if you close this PR we presume that the new pin has been rejected.

@conda-forge-admin please ping libsvm

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot.
The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.
Finally, feel free to drop us a line if there are any issues!
This PR was generated by https://github.com/regro/autotick-bot/actions/runs/480830289, please use this URL for debugging

@regro-cf-autotick-bot regro-cf-autotick-bot requested a review from a team as a code owner January 12, 2021 18:37
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/libsvm and so here I am doing that.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@bkpoon
Copy link
Member

bkpoon commented Jan 12, 2021

From the discussion in an earlier pull request for libsvm-feedstock, the ABI is stable, so updating the pin should not be necessary.

conda-forge/libsvm-feedstock#7

@beckermr
Copy link
Member

We need repodata patches and possibly updates to run exports on the feedstock.

@bkpoon
Copy link
Member

bkpoon commented Jan 12, 2021

So something like

build:
  run_exports:
    - {{ pin_subpackage('libsvm', max_pin='x.x') }}

needs to be added to the meta.yaml in libsvm-feedstock?

I can add that.

I'm not sure about repodata patches. There is currently one patch in the recipe for updating the Makefile for Windows.

@bkpoon
Copy link
Member

bkpoon commented Jan 15, 2021

From the chatter on gitter.im, it looks like I misunderstood what repodata patches mean. Is it making a pull request to https://github.com/conda-forge/conda-forge-repodata-patches-feedstock?

I recently added myself as a maintainer for libsvm to help clear out some migrations, so I'm happy to fix anything with this feedstock.

@beckermr
Copy link
Member

From the chatter on gitter.im, it looks like I misunderstood what repodata patches mean. Is it making a pull request to https://github.com/conda-forge/conda-forge-repodata-patches-feedstock?

yes!

@bkpoon bkpoon mentioned this pull request May 27, 2021
2 tasks
@hmaarrfk
Copy link
Contributor

hmaarrfk commented Sep 3, 2022

Lets just do the migration. it isn't that many feedstocks, and it helps update the compilers and refresh those recipes too.

I've merged '325'
#3368

@hmaarrfk hmaarrfk closed this Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants