-
-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to cuda 12.6 #6720
Move to cuda 12.6 #6720
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
recipe/conda_build_config.yaml
Outdated
@@ -56,7 +56,7 @@ cuda_compiler: | |||
cuda_compiler_version: | |||
- None | |||
- 11.8 # [(linux or win64) and os.environ.get("CF_CUDA_ENABLED", "False") == "True"] | |||
- 12.0 # [(linux or win64) and os.environ.get("CF_CUDA_ENABLED", "False") == "True"] | |||
- 12.6 # [(linux or win64) and os.environ.get("CF_CUDA_ENABLED", "False") == "True"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As noted previously, this won't work for linux_ppc64le
, which stops at CUDA 12.4. So that will need to be broken out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I'd still prefer a dedicated migration for this, but I guess we can bump and see as well 🤷
Did ppc get dropped from upstream? |
Yes it was deprecated in CUDA 12.4 and removed in CUDA 12.5 Edit - Also linking this tracking issue: conda-forge/cuda-feedstock#27 |
It would be nice to point recipe maintainers towards the guide we wrote for CUDA recipe maintainers, specifically around CUDA Enhanced Compatibility so that packages can be backwards compatible (use a newer compiler to build but run with an older CUDA Toolkit). If we do end up rolling this back or adding a migrator, it would be good to link to this: https://github.com/conda-forge/cuda-feedstock/blob/main/recipe/doc/recipe_guide.md#cuda-enhanced-compatibility |
Co-authored-by: jakirkham <[email protected]>
@@ -56,7 +56,8 @@ cuda_compiler: | |||
cuda_compiler_version: | |||
- None | |||
- 11.8 # [(linux or win64) and os.environ.get("CF_CUDA_ENABLED", "False") == "True"] | |||
- 12.0 # [(linux or win64) and os.environ.get("CF_CUDA_ENABLED", "False") == "True"] | |||
- 12.4 # [linux and ppc64le and os.environ.get("CF_CUDA_ENABLED", "False") == "True"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 12.4 # [linux and ppc64le and os.environ.get("CF_CUDA_ENABLED", "False") == "True"] | |
- 12.4 # [ppc64le and os.environ.get("CF_CUDA_ENABLED", "False") == "True"] |
ppc64le implies Linux.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to be explicit
Do we need to bump the cos image used for 12.6. I keep getting errors that imply that the wrong start is pulled in for 12.6 packages |
What do you mean by "start"? Some bits of the infra (esp. on aarch) already depend on glibc 2.28, but that's true even for the CUDA 12.0 bits. That will soon be solved by #6626, which is essentially ready to merge (though you could help in reviewing the announcement). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, the image changes are in, let's rock 'n' roll!
I just realised - bumping to 12.6 means we should have updated GCC pins as well. The upstream docs (found the reference in conda-forge/nvcc-feedstock#51) say that nvcc compatible with "GCC 6.x - 13.2". We're on 13.3 though. @jakirkham @bdice @carterbox, is the minor-level bound really enforced? I don't remember that in previous nvcc constraints for gcc (which were major-only AFAIR). Opened an issue for discussion, see below. |
I would assume that the minor version specification means that this is the one they have tested. |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)cc @jakirkham @carterbox @mariusvniekerk @h-vetinari
Closes #6630