Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to cuda 12.6 #6720

Merged
merged 3 commits into from
Nov 23, 2024
Merged

Move to cuda 12.6 #6720

merged 3 commits into from
Nov 23, 2024

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Nov 19, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

cc @jakirkham @carterbox @mariusvniekerk @h-vetinari

Closes #6630

@isuruf isuruf requested a review from a team as a code owner November 19, 2024 17:50
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@@ -56,7 +56,7 @@ cuda_compiler:
cuda_compiler_version:
- None
- 11.8 # [(linux or win64) and os.environ.get("CF_CUDA_ENABLED", "False") == "True"]
- 12.0 # [(linux or win64) and os.environ.get("CF_CUDA_ENABLED", "False") == "True"]
- 12.6 # [(linux or win64) and os.environ.get("CF_CUDA_ENABLED", "False") == "True"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted previously, this won't work for linux_ppc64le, which stops at CUDA 12.4. So that will need to be broken out

Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I'd still prefer a dedicated migration for this, but I guess we can bump and see as well 🤷

@hmaarrfk
Copy link
Contributor

Did ppc get dropped from upstream?

@jakirkham
Copy link
Member

jakirkham commented Nov 19, 2024

Yes it was deprecated in CUDA 12.4 and removed in CUDA 12.5

Edit - Also linking this tracking issue: conda-forge/cuda-feedstock#27

@bdice
Copy link
Contributor

bdice commented Nov 20, 2024

It would be nice to point recipe maintainers towards the guide we wrote for CUDA recipe maintainers, specifically around CUDA Enhanced Compatibility so that packages can be backwards compatible (use a newer compiler to build but run with an older CUDA Toolkit). If we do end up rolling this back or adding a migrator, it would be good to link to this: https://github.com/conda-forge/cuda-feedstock/blob/main/recipe/doc/recipe_guide.md#cuda-enhanced-compatibility

@@ -56,7 +56,8 @@ cuda_compiler:
cuda_compiler_version:
- None
- 11.8 # [(linux or win64) and os.environ.get("CF_CUDA_ENABLED", "False") == "True"]
- 12.0 # [(linux or win64) and os.environ.get("CF_CUDA_ENABLED", "False") == "True"]
- 12.4 # [linux and ppc64le and os.environ.get("CF_CUDA_ENABLED", "False") == "True"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- 12.4 # [linux and ppc64le and os.environ.get("CF_CUDA_ENABLED", "False") == "True"]
- 12.4 # [ppc64le and os.environ.get("CF_CUDA_ENABLED", "False") == "True"]

ppc64le implies Linux.

https://docs.conda.io/projects/conda-build/en/latest/resources/define-metadata.html#preprocessing-selectors

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to be explicit

@hmaarrfk
Copy link
Contributor

Do we need to bump the cos image used for 12.6. I keep getting errors that imply that the wrong start is pulled in for 12.6 packages

@h-vetinari
Copy link
Member

that the wrong start is pulled in for 12.6 packages

What do you mean by "start"? Some bits of the infra (esp. on aarch) already depend on glibc 2.28, but that's true even for the CUDA 12.0 bits. That will soon be solved by #6626, which is essentially ready to merge (though you could help in reviewing the announcement).

Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, the image changes are in, let's rock 'n' roll!

@h-vetinari h-vetinari merged commit 0154e00 into conda-forge:main Nov 23, 2024
3 checks passed
@h-vetinari
Copy link
Member

h-vetinari commented Nov 24, 2024

I just realised - bumping to 12.6 means we should have updated GCC pins as well. The upstream docs (found the reference in conda-forge/nvcc-feedstock#51) say that nvcc compatible with "GCC 6.x - 13.2". We're on 13.3 though.

@jakirkham @bdice @carterbox, is the minor-level bound really enforced? I don't remember that in previous nvcc constraints for gcc (which were major-only AFAIR).

Opened an issue for discussion, see below.

@carterbox
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate for CUDA 12.x (x to be determined)
7 participants