Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pinnings for separate suitesparse libraries #6741

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

minrk
Copy link
Member

@minrk minrk commented Nov 26, 2024

@minrk minrk requested a review from a team as a code owner November 26, 2024 13:21
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@minrk minrk force-pushed the suitesparse-split branch from efbe474 to 08796b0 Compare November 26, 2024 13:38
@h-vetinari h-vetinari marked this pull request as draft November 27, 2024 01:24
Comment on lines +483 to +494
libbtf:
- '2'
libcamd:
- '3'
libcint:
- '6.1'
libccolamd:
- '3'
libcholmod:
- '5'
libcolamd:
- '3'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm of two minds if we don't want to namespace these as coming from suitesparse somehow. I know that suitesparse more or less independent projects (hence "suite"), but we're not going to get these from anywhere else realistically? No strong opinions, just wondering...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wondered that, too! Lacking other reasons, I went with using the same names as ubuntu (suitesparse- is on mongoose, but not the others, I think because there are other pre-existing projects with the same name).

@minrk minrk marked this pull request as ready for review December 12, 2024 10:31
@minrk
Copy link
Member Author

minrk commented Dec 12, 2024

The split has landed, so this can be merged, I think

@xhochy xhochy merged commit cfaefdc into conda-forge:main Dec 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants