Version 5.1.1 breaks downstream software #35
Comments
|
Just to confirm, this is what you are talking about: |
|
I captured a bit more detail here: |
|
Looking at the But it gets pulled in with |
|
And it looks like So I am not sure if the segfault is a bad build, or because the newer version of metis isn't ABI compatible with the older version that I think first we need to add a pin to |
|
Perhaps this is related to this upstream issue: KarypisLab/METIS#69 . |
I am experiencing this problems while building from scratch spral in conda-forge/staged-recipes#18148, so I do not think this is a ABI issue. |
|
As this problem has been confirmed by several downstream packages, can't we simply roll back #32 and mark metis 5.1.1 as broken? Anyone is against this or prefer some other strategy? If there is consensus, I would be happy to open a PR to mark metis 5.1.1 as broken. @conda-forge/metis |
|
The issue is that downstream packages do not have metis pinned correctly, so an incompatible version gets pulled in. |
|
In the meantime, until the other feedstocks patch their deps, installing whatever package you want and then adding |
Are you sure that this is an ABI issue and not simply a bug in metis? I am experiencing this failure in spral that just link metis on its own, and it still segfaults. Did you try to rebuild some problematic packages and the crash was gone? |
|
This documentation here https://conda-forge.org/docs/maintainer/updating_pkgs.html#removing-broken-packages describes how to patch the package metadata, I don't have time to do this right now, but that is the cleanest fix IMHO
This is a good question 😄 Yes, I made this version build for this package conda-forge/dgl-feedstock#5 and the package builds fine, and I am able to run the tests/tutorial locally So that would be one data point that this package is okay. Another would be the tests that run in CI. Here is the log for that build: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=746883&view=logs&j=656edd35-690f-5c53-9ba3-09c10d0bea97&t=e5c8ab1d-8ff9-5cae-b332-e15ae582ed2d&l=836 and it passes. So you are correct that this build could be broken, but a package that needs this version works, and the tests that ship with this version works. So I am not saying it can't be broken (I am not a |
|
In a fresh conda env: Doesn't produce a segfault on x86-64 linux (for me). |
|
Cool, thanks for trying! I still suspect this is not just an ABI issue as it also affects spral, but for sure it is not exactly like KarypisLab/METIS#69 . |
|
@traversaro Is this the package you are trying to build? https://github.com/ralna/spral @ruizhi92 Can you give some more details about the segfault you observed? Thanks! |
|
Yes, a small reproducer would be great, anyhow I was a bit hesitant on spending time on this, given that 5.1.1 is itself quite an old metis release, and perhaps we are just debugging something that has been solved in latest metis. |
That is fair, my plan is to get a newer version out soon ™️ |
|
@mikemhenry I installed METIS version 5.1.1 with CentOS 7.9.2009, build from source, gcc compiler, c++11. When invoking METIS_PartGraphKway with the simplest program I found https://people.math.sc.edu/Burkardt/cpp_src/metis_test/metis_test.cpp, compiler reports "segmentation fault". Unfortunately I have already uninstalled version 5.1.1. Can't really see much details about the segfault then, because the error comes from the dynamic library.
|
|
Closed until I can get a reproducer, feel free to re-open/comment if anyone has any questions! |
|
Possibly related comment: KarypisLab/METIS#71 (comment) . |
|
For the spral problem with METIS >= 5.1.1, I have opened an issue upstream in ralna/spral#133 . |
Solution to issue cannot be found in the documentation.
Issue
The following script run on linux64 (ubuntu 23.04) results in a
double free or corruption (out):downgrading metis to 5.1.0 removes the error. Here metis is used via mumps, and the test that fails indeed checks the mumps wrapper.
Installed packages
Environment info
mamba info mamba version : 1.4.7 active environment : metis active env location : /home/tinkerer/.conda/envs/metis shell level : 2 user config file : /home/tinkerer/.condarc populated config files : /opt/conda/.condarc conda version : 23.5.0 conda-build version : not installed python version : 3.11.4.final.0 virtual packages : __archspec=1=x86_64 __glibc=2.35=0 __linux=3.10.0=0 __unix=0=0 base environment : /opt/conda (writable) conda av data dir : /opt/conda/etc/conda conda av metadata url : None channel URLs : https://conda.anaconda.org/conda-forge/linux-64 https://conda.anaconda.org/conda-forge/noarch package cache : /home/tinkerer/.conda/pkgs envs directories : /home/tinkerer/.conda/envs /opt/conda/envs platform : linux-64 user-agent : conda/23.5.0 requests/2.31.0 CPython/3.11.4 Linux/3.10.0-1160.25.1.el7.x86_64 ubuntu/22.04.2 glibc/2.35 UID:GID : 1004:100 netrc file : None offline mode : FalseThe text was updated successfully, but these errors were encountered: