Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ninja package does not include python package #26

Open
Anthchirp opened this issue Jan 26, 2022 · 4 comments
Open

ninja package does not include python package #26

Anthchirp opened this issue Jan 26, 2022 · 4 comments

Comments

@Anthchirp
Copy link
Member

I noticed that installing pytype (the conda-forge package) leaves an inconsistent environment (ie. pip check fails), cf. conda-forge/pytype-feedstock#46

pytype (the pypi package) has a python dependency on ninja (the pypi package).
ninja (pypi) appears to include ninja (the binary) as well as an importable python module ninja.ninja_syntax.
ninja (the conda-forge package) only includes ninja (the binary), and leaves out the python module and package.
This is why installing pytype (the conda-forge package) will lead to an inconsistent python environment.

To further confuse things...
ninja (the conda-forge package) is based off releases in the ninja repository (current: 1.10.2).
ninja (the pypi package) is allegedly also based off the ninja repository, but is currently on 1.10.2.3. But there are no traces of the python module in the ninja repository at all, so I have absolutely no idea where those files come from.
Therefore, while it would be great to add the ninja python bits to this conda-forge package and have a consistent downstream environment, I can't make a PR.

Anyone else have any ideas?

@Anthchirp
Copy link
Member Author

Found it - the ninja pypi package comes from https://github.com/scikit-build/ninja-python-distributions

@frol
Copy link
Member

frol commented Jan 29, 2022

@Anthchirp I’m not actively maintaining ninja (and conda feedstocks) anymore. I’m happy to review a PR and invite you to become a maintainer (in fact, just submit a PR adding yourself to the recipe/meta.yaml)

@rgommers
Copy link

The relevant action to take here according to #27 (comment) is to create a new feedstock for a python-ninja package. This bug report should remain open until that is done.

@weiji14
Copy link
Member

weiji14 commented May 28, 2022

I've started a PR at conda-forge/staged-recipes#19098 to add python-ninja to conda-forge. If anyone wants to be a recipe-maintainer for that, please add your GitHub username to the list!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants