-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jupyterlab 3 #52
Comments
do we know if dask-labextension is working with jupyterlab 3? I would guess that is the most likely blocker. |
Not quite. see: pangeo-data/pangeo-docker-images#174 |
dask/dask-labextension#162 for dask-labextension. I think those cleanup lines are cleaning up files from Bokeh. Whether or not they can be removed depends on if bokeh is still shipping them. IIRC nodejs is required to build jupyterlab 2.x extensions. I don't know if that's the case for 3.x extensions. |
Yeah, this update involves a decent amount of churn in the packaging, but the payoff is that there should be no more need for nodejs or a lengthy-and-expensive build process for users. All assets should just be pip/conda installable. |
glancing over at repo2docker, we will want to pay attention to jupyterhub/repo2docker#956 as well. for now we are temporarily pinning jupyterlab=2, ipywidgets=7, dask-labextension=3 at major versions and not updating to new versions via CI (#54) |
closed by #59 |
We currently pin Jlab>=2. Jupyterlab3 which includes new extensions (https://jupyterlab.readthedocs.io/en/stable/getting_started/changelog.html)
see also:
https://www.quansight.com/post/why-we-are-excited-about-jupyterlab-3-0-dynamic-extensions
so I believe our options are 1) pin to jlab=2 for now or 2) keep pin as is and wait for extensions to update before building new images
pangeo-notebook-feedstock/recipe/meta.yaml
Lines 13 to 20 in ec9db37
@consideRatio or @TomAugspurger is NodeJS used for other things? If we can drop it as a dependency that would be nice because it would reduce image size and we could remove these 'clean up' lines in Docker images
https://github.com/pangeo-data/pangeo-docker-images/blob/8cebf16a73bfd3f74a22353e176fa21eb7435c96/base-image/Dockerfile#L98-L99
The text was updated successfully, but these errors were encountered: