Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyterlab 3 #52

Closed
scottyhq opened this issue Jan 4, 2021 · 6 comments
Closed

Jupyterlab 3 #52

scottyhq opened this issue Jan 4, 2021 · 6 comments

Comments

@scottyhq
Copy link
Contributor

scottyhq commented Jan 4, 2021

We currently pin Jlab>=2. Jupyterlab3 which includes new extensions (https://jupyterlab.readthedocs.io/en/stable/getting_started/changelog.html)

see also:
https://www.quansight.com/post/why-we-are-excited-about-jupyterlab-3-0-dynamic-extensions

so I believe our options are 1) pin to jlab=2 for now or 2) keep pin as is and wait for extensions to update before building new images

- pangeo-dask =2020.12.11
- dask-labextension =4.0.1
- ipywidgets =7.5.1
- jupyter-server-proxy =1.5.2
- jupyterhub-singleuser =1.3.0
- jupyterlab >=2
- nbgitpuller =0.9.0
- nodejs >=12

@consideRatio or @TomAugspurger is NodeJS used for other things? If we can drop it as a dependency that would be nice because it would reduce image size and we could remove these 'clean up' lines in Docker images

https://github.com/pangeo-data/pangeo-docker-images/blob/8cebf16a73bfd3f74a22353e176fa21eb7435c96/base-image/Dockerfile#L98-L99

@jhamman
Copy link
Member

jhamman commented Jan 4, 2021

do we know if dask-labextension is working with jupyterlab 3? I would guess that is the most likely blocker.

@scottyhq
Copy link
Contributor Author

scottyhq commented Jan 4, 2021

do we know if dask-labextension is working with jupyterlab 3? I would guess that is the most likely blocker.

Not quite. see: pangeo-data/pangeo-docker-images#174

@TomAugspurger
Copy link
Contributor

dask/dask-labextension#162 for dask-labextension.

I think those cleanup lines are cleaning up files from Bokeh. Whether or not they can be removed depends on if bokeh is still shipping them.

IIRC nodejs is required to build jupyterlab 2.x extensions. I don't know if that's the case for 3.x extensions.

@ian-r-rose
Copy link

IIRC nodejs is required to build jupyterlab 2.x extensions. I don't know if that's the case for 3.x extensions.

Yeah, this update involves a decent amount of churn in the packaging, but the payoff is that there should be no more need for nodejs or a lengthy-and-expensive build process for users. All assets should just be pip/conda installable.

@scottyhq scottyhq mentioned this issue Jan 5, 2021
5 tasks
@scottyhq
Copy link
Contributor Author

glancing over at repo2docker, we will want to pay attention to jupyterhub/repo2docker#956 as well.

for now we are temporarily pinning jupyterlab=2, ipywidgets=7, dask-labextension=3 at major versions and not updating to new versions via CI (#54)

@scottyhq scottyhq mentioned this issue Mar 1, 2021
5 tasks
@scottyhq
Copy link
Contributor Author

scottyhq commented Mar 2, 2021

closed by #59

@scottyhq scottyhq closed this as completed Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants