Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor recipe updates #46

Merged
merged 6 commits into from
Feb 16, 2022
Merged

Minor recipe updates #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f4402d6
Add 'pip check' to tests
Anthchirp Jan 26, 2022
0ebb3ed
Recipe updates
Anthchirp Jan 26, 2022
8657a9b
Remove pip check again
Anthchirp Jan 26, 2022
f12ef28
MNT: Re-rendered with conda-build 3.21.7, conda-smithy 3.16.2, and co…
Jan 26, 2022
f629b66
add myself as maintainer
Anthchirp Jan 26, 2022
f811a2d
MNT: Re-rendered with conda-build 3.21.7, conda-smithy 3.16.2, and co…
Jan 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion LICENSE.txt
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions README.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 8 additions & 8 deletions recipe/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ source:
folder: typeshed

build:
number: 0
skip: true # [py<36 or py>=310 or win]
number: 1
skip: true # [py>=310 or win]
# no windows builds here: https://pypi.org/project/pytype/#files
entry_points:
- annotate-ast = pytype.tools.annotate_ast.main:main
Expand All @@ -44,14 +44,13 @@ requirements:
- python
Copy link
Member

@marcelotrevisani marcelotrevisani Jan 26, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't it need pybind11?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/google/pytype/blob/07662febd183e4a3395e05ea8d3adf75397bd7cb/pyproject.toml#L2

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how this is passing without it: https://github.com/google/pytype/blob/07662febd183e4a3395e05ea8d3adf75397bd7cb/setup.py#L18-L24

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's pulling in a pybind11 folder in line 16? I didn't look into the extra files.
Looking at them now - those are not actually patch sets but are pulling in some specific commit revisions of googletest, pybind11, and typeshed. These probably should be build-/test-time dependencies.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! https://github.com/Anthchirp/pytype-feedstock/blob/f811a2dd93459a3cf28ea5fdb853814388ca2c19/recipe/meta.yaml#L13-L21

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you wanna unvendor these or nah?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no real need --- the pkg doesn't end up taking these deps with it; they're just needed at build time, I believe.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be neater to unvendor, but I feel that's a separate endeavour

run:
- attrs >=21.2.0
- dataclasses
- importlab >=0.6.1
- ninja >=1.10.0
- tabulate
- toml
- typed-ast >=1.5.0
- importlab >=0.7
- libcst
- ninja >=1.10.0.post2
- python
- tabulate
- toml
- typed-ast >=1.5.0 # [py<38]

test:
imports:
Expand All @@ -75,3 +74,4 @@ extra:
recipe-maintainers:
- ngam
- marcelotrevisani
- anthchirp