Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tensorflow-privacy #29076

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add tensorflow-privacy #29076

wants to merge 3 commits into from

Conversation

rpreen
Copy link
Member

@rpreen rpreen commented Feb 10, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/tensorflow-privacy/meta.yaml) and found it was in an excellent condition.

@rpreen
Copy link
Member Author

rpreen commented Feb 10, 2025

@conda-forge/help-python, ready for review!

It seems to build fine on linux, but is failing on mac and windows, and I'm not sure how to fix that - the package is noarch: python so maybe doesn't matter?

@manics
Copy link
Member

manics commented Feb 26, 2025

I can reproduce the build failure on OS X when running python setup.py build. The source includes a file called BUILD. The build process tries to create a directory called build which works on Linux, but fails on OS X because the filesystem is case-insensitive (though case is maintained when displaying names). I think if you rename BUILD to BUILD.txt this should successfully build.

Windows is failing with

Encountered problems while solving:
  - nothing provides tensorflow-base >=2.14.0,<2.15.0 needed by tensorflow-probability-0.22.1-pyh4af843d_1
  - unsupported request

Builds for tensorflow2 are broken for Windows:
conda-forge/tensorflow-feedstock#124
so unfortunately I think you'll need to skip Windows

@manics
Copy link
Member

manics commented Feb 26, 2025

I've opened an upstream issue for the BUILD/build problem tensorflow/privacy#612

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants