Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recipe for vllm #24710

Open
wants to merge 64 commits into
base: main
Choose a base branch
from
Open

recipe for vllm #24710

wants to merge 64 commits into from

Conversation

mediocretech
Copy link
Contributor

@mediocretech mediocretech commented Dec 7, 2023

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/vllm) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/vllm) and found some lint.

Here's what I've got...

For recipes/vllm:

  • noarch packages can't have skips with selectors. If the selectors are necessary, please remove noarch: python.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/vllm) and found it was in an excellent condition.

@mediocretech
Copy link
Contributor Author

Blocked by #24850

@iamthebot
Copy link
Contributor

iamthebot commented Feb 29, 2024

@mediocretech this isn't actually blocked. Please see this issue. tl;dr only the ninja package is actually needed there isn't a need for ninja-python. The Deepspeed conda package, as a result, does not do the pip check but the package works just fine.

Remove the pip check like deepspeed does.

Let me know if you'd like someone to take over this PR if you don't have bandwidth to make the changes. Would love to have this merged soon.

@mediocretech
Copy link
Contributor Author

mediocretech commented Mar 1, 2024 via email

@iamthebot
Copy link
Contributor

@mediocretech I think the build is failing due to crypt.h being missing which implies libxcrypt needs to be a "host" dependency.

recipes/vllm/meta.yaml Show resolved Hide resolved
recipes/vllm/meta.yaml Show resolved Hide resolved
recipes/vllm/meta.yaml Outdated Show resolved Hide resolved
@c3-ali
Copy link

c3-ali commented May 9, 2024

@iamthebot @mediocretech thanks for creating the PR and fixes. What's currently blocking the merge? ETA?

@iamthebot
Copy link
Contributor

@c3-ali there were some linker references that were causing CI to fail. I'm pretty swamped at the moment so probably can't get to this until ~1-2 weeks from now.

@mediocretech
Copy link
Contributor Author

@iamthebot
Copy link
Contributor

iamthebot commented May 22, 2024

@mediocretech sounds like that was fixed in this PR. But yeah, you're right the (openai) triton feedstock is super out of date. Let me see how hard that is to update

@iamthebot
Copy link
Contributor

iamthebot commented May 22, 2024

OK, created an issue in the triton feedstock. Will work on that one first. That'll be a blocker to new pytorch packages if we want to unvendor triton there anyways. The original blocker for updating to triton 2.1.x is no longer there per-se.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/vllm/meta.yaml) and found it was in an excellent condition.

Copy link

github-actions bot commented Aug 1, 2024

Hi! Thanks for your contribution to conda-forge.
We appreciate your effort in improving our project.
However, it looks like some changes were made outside the recipes directory.
To ensure everything runs smoothly, please make sure that recipes are only added to the recipes folder and no other files are changed.
Please make sure that any changes are reverted before you submit your pull request for review.

If these changes are intentional (and you aren't submitting a recipe), please attach a maintenance label to the PR.
Thanks!

Copy link

github-actions bot commented Aug 1, 2024

Hi! Thanks for your contribution to conda-forge.
We appreciate your effort in improving our project.
However, it looks like some changes were made outside the recipes directory.
To ensure everything runs smoothly, please make sure that recipes are only added to the recipes folder and no other files are changed.
Please make sure that any changes are reverted before you submit your pull request for review.

If these changes are intentional (and you aren't submitting a recipe), please attach a maintenance label to the PR.
Thanks!

Copy link

github-actions bot commented Aug 1, 2024

Hi! Thanks for your contribution to conda-forge.
We appreciate your effort in improving our project.
However, it looks like some changes were made outside the recipes directory.
To ensure everything runs smoothly, please make sure that recipes are only added to the recipes folder and no other files are changed.
Please make sure that any changes are reverted before you submit your pull request for review.

If these changes are intentional (and you aren't submitting a recipe), please attach a maintenance label to the PR.
Thanks!

Copy link

github-actions bot commented Aug 1, 2024

Hi! Thanks for your contribution to conda-forge.
We appreciate your effort in improving our project.
However, it looks like some changes were made outside the recipes directory.
To ensure everything runs smoothly, please make sure that recipes are only added to the recipes folder and no other files are changed.
Please make sure that any changes are reverted before you submit your pull request for review.

If these changes are intentional (and you aren't submitting a recipe), please attach a maintenance label to the PR.
Thanks!

@mediocretech
Copy link
Contributor Author

@iamthebot few more attempts made. Triton is looking blocked, see conda-forge/triton-feedstock#23

@iamthebot
Copy link
Contributor

@mediocretech basically the next steps for triton are listed here.

Unfortunately I'm pretty swamped for the rest of the quarter. I can probably come back to this late october.

Copy link

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants