-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
recipe for vllm #24710
base: main
Are you sure you want to change the base?
recipe for vllm #24710
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/vllm:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Blocked by #24850 |
@mediocretech this isn't actually blocked. Please see this issue. tl;dr only the Remove the pip check like deepspeed does. Let me know if you'd like someone to take over this PR if you don't have bandwidth to make the changes. Would love to have this merged soon. |
Thanks @iamthebot! I'll make the change today.
|
@mediocretech I think the build is failing due to |
@iamthebot @mediocretech thanks for creating the PR and fixes. What's currently blocking the merge? ETA? |
@c3-ali there were some linker references that were causing CI to fail. I'm pretty swamped at the moment so probably can't get to this until ~1-2 weeks from now. |
Now receiving Triton error: Potentially related that Triton Feedstock is outdated. |
@mediocretech sounds like that was fixed in this PR. But yeah, you're right the (openai) triton feedstock is super out of date. Let me see how hard that is to update |
OK, created an issue in the triton feedstock. Will work on that one first. That'll be a blocker to new pytorch packages if we want to unvendor triton there anyways. The original blocker for updating to triton 2.1.x is no longer there per-se. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! Thanks for your contribution to conda-forge. If these changes are intentional (and you aren't submitting a recipe), please attach a |
Hi! Thanks for your contribution to conda-forge. If these changes are intentional (and you aren't submitting a recipe), please attach a |
Hi! Thanks for your contribution to conda-forge. If these changes are intentional (and you aren't submitting a recipe), please attach a |
Hi! Thanks for your contribution to conda-forge. If these changes are intentional (and you aren't submitting a recipe), please attach a |
@iamthebot few more attempts made. Triton is looking blocked, see conda-forge/triton-feedstock#23 |
@mediocretech basically the next steps for triton are listed here. Unfortunately I'm pretty swamped for the rest of the quarter. I can probably come back to this late october. |
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).