Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add recipe for optype #28396

Merged
merged 5 commits into from
Nov 29, 2024
Merged

add recipe for optype #28396

merged 5 commits into from
Nov 29, 2024

Conversation

lucascolley
Copy link
Member

@lucascolley lucascolley commented Nov 28, 2024

cc @jorenham (the linter will want you to comment here)

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/optype/meta.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: jorenham. Please ask them to comment on this PR if they are.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 28, 2024

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/optype/meta.yaml) and found some lint.

Here's what I've got...

For recipes/optype/meta.yaml:

  • ❌ Non noarch packages should have python requirement without any version constraints.
  • ❌ Non noarch packages should have python requirement without any version constraints.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12075043139. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/optype/meta.yaml) and found it was in an excellent condition.

@jorenham
Copy link

This has my blessing, and was discussed before in scipy/scipy-stubs#216 👌🏻

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@lucascolley lucascolley marked this pull request as ready for review November 28, 2024 20:38
@lucascolley
Copy link
Member Author

@conda-forge/help-python ready for review, thanks! :)

@xhochy xhochy merged commit 12385dc into conda-forge:main Nov 29, 2024
7 checks passed
@lucascolley lucascolley deleted the optype branch November 29, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants