Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] - Bump to latest Node.js #416

Closed
gabalafou opened this issue Sep 5, 2024 · 2 comments · Fixed by #415
Closed

[ENH] - Bump to latest Node.js #416

gabalafou opened this issue Sep 5, 2024 · 2 comments · Fixed by #415

Comments

@gabalafou
Copy link
Contributor

Feature description

We are currently using Node 18

Value and/or benefit

Node is already at version 22, so we're two versions behind.

Anything else?

No response

@trallard
Copy link
Collaborator

trallard commented Sep 5, 2024

We are not using 18.x, we have "node": ">=18.0.0" in our package.json which, depending on when one last updated/created their env should be on the latest point release of node (for example right now should be on 22.x)

I think the action here would be to bump the minimum version to 22 based on the Node EOL calendar https://endoflife.date/nodejs (technically we could go to 20 but everything seems to work on 22)

@trallard
Copy link
Collaborator

trallard commented Sep 6, 2024

Left a comment in #415 we can address this in that PR directly or do a stack of PRs

@gabalafou gabalafou linked a pull request Sep 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants