Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.solv files not being reused #481

Open
2 tasks done
tl-hbk opened this issue Jun 26, 2024 · 1 comment · May be fixed by #482
Open
2 tasks done

.solv files not being reused #481

tl-hbk opened this issue Jun 26, 2024 · 1 comment · May be fixed by #482
Labels
type::bug describes erroneous operation, use severity::* to classify the type

Comments

@tl-hbk
Copy link
Contributor

tl-hbk commented Jun 26, 2024 •
edited
Loading

Checklist

  • I added a descriptive title
  • I searched open reports and couldn't find a duplicate

What happened?

It looks like in the following commit 8d9d6c0

a try_solv argument was added to _json_path_to_repo_info which defaults to False.

From what I can tell this was added so that reload_local_channels could invalidate the .solv files but only other call to _json_path_to_repo_info in _load_channels did not get updated to use try_solv=True.

This is causing every solve attempt to parse the repodata json and regenerate the .solv files even when all the channels are cache hits. This leads to a performance hit.

Conda Info

No response

Conda Config

No response

Conda list

No response

Additional Context

No response
@tl-hbk tl-hbk added the type::bug describes erroneous operation, use severity::* to classify the type label Jun 26, 2024
@jaimergp
Copy link
Contributor

jaimergp commented Jul 1, 2024

Oh, excellent catch and just in time for a release, I'd say.

@jaimergp jaimergp linked a pull request Jul 1, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type::bug describes erroneous operation, use severity::* to classify the type
Projects
🧭 Planning
Status: 🆕 New
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do try to load .solv files by default conda/conda-libmamba-solver
2 participants
@jaimergp @tl-hbk