Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liveness/readiness endpoints #108

Open
eroznik opened this issue Jun 7, 2021 · 3 comments
Open

Liveness/readiness endpoints #108

eroznik opened this issue Jun 7, 2021 · 3 comments

Comments

@eroznik
Copy link

eroznik commented Jun 7, 2021

Hello,
Just wondering if this would be a good addition to the project?

Liveness could probably check that ACLs were synced successfully in the last configured sync interval. Readiness would be no-op, just return a 200.. since there is no public API(for now).

Thoughts?

@simplesteph
Copy link
Contributor

yeah, something like a health-check point would be great

@eroznik
Copy link
Author

eroznik commented Jun 7, 2021

does the described implementation make sense? i checked the code and couldn't find anything "more suitable" 🤔

@simplesteph
Copy link
Contributor

simplesteph commented Jun 7, 2021 via email

eroznik added a commit to eroznik/kafka-security-manager that referenced this issue Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants