Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Secret Manager as Source #81

Open
brunodomenici opened this issue Jun 3, 2020 · 1 comment
Open

Google Secret Manager as Source #81

brunodomenici opened this issue Jun 3, 2020 · 1 comment

Comments

@brunodomenici
Copy link
Contributor

Hi,

I do have an internal need to implement Google Secret Manager as Source.
I've already implemented the source and I'd like to contribute to the project, if your guys are interested 😄

The idea is to have many secrets as needed (because we have a 64kb payload limit) in GCP with the contents of ACL and filter by labels (optional), for example:

  • secret-acl-test:
User:alice,Topic,LITERAL,foo,Read,Allow,*
User:bob,Group,bar,PREFIXED,Write,Deny,12.34.56.78
User:peter,Cluster,LITERAL,kafka-cluster,Create,Allow,*
  • secret-acl-tes2:
User:alice,Topic,LITERAL,foo,Read,Allow,*
User:jeff,Group,bar,PREFIXED,Write,Deny,12.34.56.78
User:john,Cluster,LITERAL,kafka-cluster,Create,Allow,*

We query all secrets, apply the filter and return the string with all ACLs (with header):

KafkaPrincipal,ResourceType,PatternType,ResourceName,Operation,PermissionType,Host

User:alice,Topic,LITERAL,foo,Read,Allow,*
User:bob,Group,bar,PREFIXED,Write,Deny,12.34.56.78
User:peter,Cluster,LITERAL,kafka-cluster,Create,Allow,*
User:alice,Topic,LITERAL,foo,Read,Allow,*
User:jeff,Group,bar,PREFIXED,Write,Deny,12.34.56.78
User:john,Cluster,LITERAL,kafka-cluster,Create,Allow,*

Config:

New config section:

  gcp-secret-manager {
    projectid = ${?SOURCE_GCP_PROJECTID}
    label_filter = ${?SOURCE_GCP_LABEL_FILTER}
  }

Let me know if you are interested, I can open the PR.

Thanks and nice project!

@simplesteph
Copy link
Contributor

simplesteph commented Jun 3, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants