Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple calls to SetStatisticsHandler / SetLogHandler / SetErrorHandler #2154

Open
g7ed6e opened this issue Dec 12, 2023 · 0 comments · May be fixed by #2155
Open

Allow multiple calls to SetStatisticsHandler / SetLogHandler / SetErrorHandler #2154

g7ed6e opened this issue Dec 12, 2023 · 0 comments · May be fixed by #2155

Comments

@g7ed6e
Copy link

g7ed6e commented Dec 12, 2023

The LogHandler and the StatisticsHandler are protected internal non virtual multicast delegates. This visibility and the fact that current implementation throw when a SetXXXHandler is called multiple times defeats the purpose of multicast delegates and make implementation of a 3rd party package using these delegates fragile. I’m thinking there to the implementation of an instrumentation packages for example.

@g7ed6e g7ed6e changed the title Allow multiple calls to XXXBuilder.SetXXXHandler Allow multiple calls to SetStatisticsHandler / SetLogHandler / SetErrorHandler Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant