Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: ability to disable some reference checks #888

Open
jhump opened this issue Jun 14, 2024 · 0 comments
Open

enhancement: ability to disable some reference checks #888

jhump opened this issue Jun 14, 2024 · 0 comments

Comments

@jhump
Copy link
Member

jhump commented Jun 14, 2024

Currently, the reference server and reference client make additional assertions about the peer's protocol implementation by examining wire-level details and checking for well-formedness. But some of the checks could really be considered "recommendations", not "requirements", largely in the spirit of the robustness principle (be strict about what you emit, but be lenient about what you accept). For example, if the "grpc-status-details-bin" trailer value uses base64 padding, the reference client complains with an error. The spec states, however, that servers should emit unpadded values, not must. Currently, these checks cause test cases to fail.

Ideally, each of these extra assertions could be given a unique name and that name could then be used to disable them, either in a config file or via command-line flag. This would allow us to more clearly separate required vs. recommended checks and to allow implementations that only do what's required (and not what's recommended) to still pass tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant