Fix retain cycle between URLSessionHTTPClient
and URLSession.delegate
#335
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #334 for more information on the underlying issue.
This PR creates a private
URLSessionDelegateWrapper
class to act as an intermediary betweenURLSessionHTTPClient
andURLSession.delegate
. From the inline documentation I added:The client now also calls
self.session.finishTasksAndInvalidate()
ondeinit
.This workaround isn't the cleanest, but it does solve the issue and I'm not sure there's a better way of doing it. Open to suggestions, though.
I also made the builder function in the example app
static
to avoid capturingself
in the builder closures.With these changes, I was able to confirm the cycle demonstrated in the above issue is resolved in the memory debugger:
Note that I avoided changing the
open func
signatures ofURLSessionHTTPClient
since that would be a breaking API change.Resolves #334.