Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OomGroupKill in cgroup2 memory events stats #274

Open
sparrc opened this issue Mar 17, 2023 · 0 comments
Open

Support OomGroupKill in cgroup2 memory events stats #274

sparrc opened this issue Mar 17, 2023 · 0 comments

Comments

@sparrc
Copy link
Contributor

sparrc commented Mar 17, 2023

oom_group_kill cgroup events have been added to the linux kernel around a year ago: torvalds/linux@b6bf9ab

This is an event which tracks how many times the entire cgroup is "group" killed, in addition to the single process oom kills tracked by the existing oom_kill event. See https://docs.kernel.org/admin-guide/cgroup-v2.html#controllers for details about oom grouping:

memory.oom.group

    A read-write single value file which exists on non-root cgroups. The default value is "0".

    Determines whether the cgroup should be treated as an indivisible workload by the OOM killer. If set, all tasks belonging to the cgroup or to its descendants (if the memory cgroup is not a leaf cgroup) are killed together or not at all. This can be used to avoid partial kills to guarantee workload integrity.

...

I believe support for this event will need to be added to these three places (see existing oom_kill event for example):
https://github.com/containerd/cgroups/blob/main/cgroup2/stats/metrics.proto
https://github.com/containerd/cgroups/blob/main/cgroup2/stats/metrics.pb.txt
https://github.com/containerd/cgroups/blob/main/cgroup2/manager.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant